1010402 - Clickable area of sync datatypes too large

Status: VERIFIED FIXED

(Firefox :: Sync, defect)

Description

[Ryan Feeley [:rfeeley]]

Attachment: hit-area.gif

Currently the hit (clickable) area of the sync datatype selections is a full block, but should be limited to just the checkbox and its label. When the hit area is too large, users may accidentally provide their account with personal data, like saved passwords, they may not intend to.

Comment 1

[:Gavin Sharp [email: [e-mail]]]

Sounds like my fix for bug 982167 just needs porting to the data type selection dialog (browser/base/content/sync/customize.xul).

Comment 2

[Ryan Feeley [:rfeeley]]

Attachment: signin.gif

Also an issue in the unauthenticated state. See attached.

Comment 3

[Mike Hoye [:mhoye]]

Relabeling good-next; this looks straightforward, but touching UX and migrating a fix means it's not a starter bug.

Comment 4

[:Gavin Sharp [email: [e-mail]]]

I disagree - this bug is very easy to test, requires minimal changes, and that there is an existing patch that illustrates the general approach makes it easier, not harder.

Comment 5

[Bernardo Rittmeyer [:rittme]]

I would like to work on this bug, if someone could assign me to it, please.

Also, there is the same problem at the Manage label.

Comment 6

[Bernardo Rittmeyer [:rittme]]

Attachment: manage label clickable area

Comment 7

[Mike Conley (:mconley) (:⚙️)]

So Bernardo, I originally thought that this would be a WONTFIX since it's not a problem in in-content prefs - but with in-content prefs being blocked by a number of things and maybe-not shipping for a few releases, I think we should try to tackle this anyways.

I think it'd be good to cut your teeth on.

Let me know if you have any questions about this bug (please needinfo me - see next to the "Save Changes" button at the bottom of this page - just put my e-mail address in there).

Comment 8

[Bernardo Rittmeyer [:rittme]]

Nice! So I have some questions about the backporting of this bug and the repository I should use.

I can reproduce the label bugs in aurora and release, but the checkboxes are already working fine in Aurora (on Windows and Linux).

Should I work the patch using mozilla-central repository or should I use another release?

Comment 9

[Mike Conley (:mconley) (:⚙️)]

Hey Bernardo,

You should start working on mozilla-central first, and then we can backport to mozilla-aurora and beta if necessary.

Comment 10

[Bernardo Rittmeyer [:rittme]]

Attachment: rev1 sync clickable areas fix

I think this should work. 
I used the approach Gavin suggested (like in bug 982167).

Comment 11

[Bernardo Rittmeyer [:rittme]]

Attachment: rev2 sync clickable areas fix

While working on bug 1020422 I found out a cleaner solution using the align="start" attribute.

Comment 12

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8435827 [details] [diff] [review]
rev2 sync clickable areas fix

Review of attachment 8435827 [details] [diff] [review]:
-----------------------------------------------------------------

This code looks good to me! I've also tested it, and can confirm this resolves the issues when applied.

Thanks Bernardo! Great work!

Comment 13

[Mike Conley (:mconley) (:⚙️)]

Hey Marco, mind adding this to the current iteration? Bernardo's got this in the bag.

Comment 14

[Marco Mucci [:MarcoM]]

Added to Iteration 32.3

Comment 15

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/c08592c634fc

Comment 16

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/c08592c634fc

Comment 17

[Camelia Badau [:cbadau], Desktop Test Engineering]

Verified on Windows 7 64bit, Ubuntu 13.10 32bit and Mac OSX 10.8.5 using latest Aurora 32.0a2 (buildID: 	20140611004004) and the only remaining problem is the one mentioned in bug 1023339 ("for the Sync tab, when FxA account is connected, the clickable area is NOT limited to the checkbox and it's label").